[PATCH] D116928: [LoopVectorize] Support epilogue vectorisation of loops with reductions

[David Sherwood via Phabricator via llvm-commits]

david-arm added inline comments.


================
Comment at: llvm/test/Transforms/LoopVectorize/epilog-vectorization-reductions.ll:200
+;
+; Integer reduction which requires scalarising as we cannot use gather/scatter
+;
----------------
sdesmalen wrote:
> Again, I'm not entirely sure of the value of testing this case? (as in, how it relates to this patch)
I think this might be a test that I asked @kmclaughlin to add because I wanted to make sure we used the correct PHI type in the epilogue loop too. This exposes a case where we detect reductions using the `lookThroughAnd` vectoriser function. The actual reduction`llvm.vector.reduce.or.v4i16` uses a different type to the PHI.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116928/new/

https://reviews.llvm.org/D116928