[PATCH] D117429: [AArch64] Revive optimize add/sub with immediate through MIPeepholeOpt

Mon Jan 17 05:37:23 PST 2022

red1bluelost added a comment.

In D117429#3248015 <https://reviews.llvm.org/D117429#3248015>, @dmgreen wrote:

> So this now does the same as visitORR? LGTM in that case, thanks for pushing this through!

I don't think it is the same as visitORR. If you meant visitAND, I just checked an they are very similar expect differences where AND uses `splitBitmaskImm` while ADDSUB uses `splitAndSubImm`. Also the building of the ADDSUB MI's has an additional immediate for the shift value.

I'll try to see if it would be worth while to abstract the similarities after I add the SUBS instruction.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117429/new/

https://reviews.llvm.org/D117429