[PATCH] D117016: [flang][examples] Add missing CMake dependencies

Valentin Clement via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 17 04:49:55 PST 2022


clementval added a comment.

In D117016#3243970 <https://reviews.llvm.org/D117016#3243970>, @awarzynski wrote:

> In D117016#3243872 <https://reviews.llvm.org/D117016#3243872>, @clementval wrote:
>
>>> I agree. We'd probably have to remove these *.inc files from all header files. I can't think of any other way.
>>
>> Why would you remove them?
>
> So that various CMake targets don't depend on `acc_gen` or `omp_gen`. To me it's rather counter-intuitive that everything that includes `parse-tree.h` depends on `acc_gen` and `omp_gen`. But perhaps that's by design?
>
> Anyway, @clementval , are you OK with this change?

I'm ok with the change. The only solution would be to extract OpenMP and OpenACC specific parts to their own include files but in your example you would need the `omp_gen` dependency.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117016/new/

https://reviews.llvm.org/D117016



More information about the llvm-commits mailing list