[PATCH] D117284: [ELF] Allow non-bitcode archive with an empty index

[Igor Kudrin via Phabricator via llvm-commits]

ikudrin accepted this revision.
ikudrin added a comment.
This revision is now accepted and ready to land.

LGTM.

The change looks safe. If it eventually helps us to move towards a parallel reading of input files, I am in favor of it.



================
Comment at: lld/test/ELF/lto/archive-no-index.ll:27
 ; RUN: llvm-ar crS %t3.a %t3.o
-; RUN: not ld.lld -o /dev/null -emain %t1.o %t3.a 2>&1 | FileCheck -check-prefix=ERR1 %s
-; ERR1: error: {{.*}}.a: archive has no index; run ranlib to add one
+; RUN: not ld.lld -o %t -emain %t1.o %t3.a 2>&1 | FileCheck --check-prefix=ERR2 %s
 
----------------



================
Comment at: lld/test/ELF/lto/archive-no-index.ll:31-32
 ; RUN: llvm-ar cr %t4.a
 ; RUN: not ld.lld -o /dev/null -emain %t1.o %t4.a 2>&1 | FileCheck -check-prefix=ERR2 %s
 ; ERR2: error: undefined symbol: f
----------------
There is only one error message in the test now, so the prefix can be just `ERR`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117284/new/

https://reviews.llvm.org/D117284