[PATCH] D117307: [LoopVectorize] Only check for ordered reductions if the op chain was found

[David Sherwood via Phabricator via llvm-commits]

david-arm added a comment.

The patch looks good to me @kmclaughlin! I just had one suggestion about maybe leaving the function where it was before.



================
Comment at: llvm/lib/Analysis/IVDescriptors.cpp:206
 
+SmallVector<Instruction *, 4> getReductionOpChain(PHINode *Phi, Loop *L,
+                                                  Instruction *LoopExitInstr,
----------------
Maybe it's better to leave this function where it was originally so that it's easier to see what's changed? It seems to be just the declaration that's different I think?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117307/new/

https://reviews.llvm.org/D117307