[PATCH] D116998: [LangRef] Don't allow read from sret memory after unwind

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 17 02:56:53 PST 2022


nikic added a reviewer: rnk.
nikic added a subscriber: rnk.
nikic added a comment.

In D116998#3234540 <https://reviews.llvm.org/D116998#3234540>, @reames wrote:

> This looks reasonable, but I don't really have the context on sret to understand any implicit assumptions made in current usage.  I'd encourage you to find someone with current context to approve.  If you can't, I can take the time to build it, but that's somewhat expensive time wise, so I'd really prefer not to it.

Not sure who would be familiar, maybe @rnk.

The intuition here is that sret is basically the function return value, just passed indirectly, and you can't read a function return value on unwind.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116998/new/

https://reviews.llvm.org/D116998



More information about the llvm-commits mailing list