[PATCH] D116103: [VE] VECustomDAG builder class

[Simon Moll via Phabricator via llvm-commits]

simoll added inline comments.


================
Comment at: llvm/lib/Target/VE/VECustomDAG.h:9-10
+//
+// This file defines the interfaces that VE uses to lower LLVM code into a
+// selection DAG.
+//
----------------
kaz7 wrote:
> How about explaining this like.  It's much better to work to lower expectation from the name "CustomDAG".
> ```
> This file defines the helper functions that VE uses to lower LLVM code into
> a selection DAG.  For example, hiding SDLoc, and easy to use SDNodeFlags.
> ```
That's a good idea. I'll take your suggestion.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116103/new/

https://reviews.llvm.org/D116103