[PATCH] D117452: [RISCV] Provide VLOperand in td.

Fraser Cormack via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 17 02:48:48 PST 2022


frasercrmck accepted this revision.
frasercrmck added a comment.

LGTM otherwise



================
Comment at: llvm/include/llvm/IR/IntrinsicsRISCV.td:126
 
+// This is used to present VL operand does not exist.
+// (e.g., riscv_vmv_x_s and riscv_vfmv_f_s)
----------------
Sorry as this is super nitty but the comment still doesn't read well to me. Maybe `The intrinsic does not have a VL operand.` as that also fits the description of `NoSplatOperand`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117452/new/

https://reviews.llvm.org/D117452



More information about the llvm-commits mailing list