[PATCH] D116103: [VE] VECustomDAG builder class

Kazushi Marukawa via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 17 02:45:41 PST 2022


kaz7 added a comment.

Sorry for delay of reviewing.  Please add little more explanation to a head file.



================
Comment at: llvm/lib/Target/VE/VECustomDAG.h:9-10
+//
+// This file defines the interfaces that VE uses to lower LLVM code into a
+// selection DAG.
+//
----------------
How about explaining this like.  It's much better to work to lower expectation from the name "CustomDAG".
```
This file defines the helper functions that VE uses to lower LLVM code into
a selection DAG.  For example, hiding SDLoc, and easy to use SDNodeFlags.
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116103/new/

https://reviews.llvm.org/D116103



More information about the llvm-commits mailing list