[PATCH] D115702: [LNT] Fix profile assigning to tests

Thomas Preud'homme via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 17 02:29:04 PST 2022


thopre added inline comments.


================
Comment at: lnt/server/db/testsuitedb.py:1044
         for test_data in tests_data:
+            if len(test_data) == 2 and 'profile' in test_data:
+                # Ignore for now profile data without other metrics
----------------
If a profile is determined by having the name ends in .profile I'd prefer to check that explicitely (i.e. `test_data['name'].endswith('profie')`)


================
Comment at: lnt/server/db/testsuitedb.py:1077
+        for test_data in tests_data:
+            if len(test_data) != 2 or 'profile' not in test_data:
+                continue
----------------
And mirror it here, perhaps introduce a "is_profile" lambda.


Repository:
  rLNT LNT

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115702/new/

https://reviews.llvm.org/D115702



More information about the llvm-commits mailing list