[PATCH] D117135: AMDGPU/GlobalISel: Fold wave address into mubuf addressing modes

[Sebastian Neubauer via Phabricator via llvm-commits]

sebastian-ne added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp:3921
+// Return the wave level SGPR base address if this is a wave address.
+static Register isWaveAddress(const MachineInstr *Def) {
+  return Def->getOpcode() == AMDGPU::G_AMDGPU_WAVE_ADDRESS
----------------
How about calling this `getWaveAddress` or something similar?
`isWaveAddress` sounds like it’s returning a bool, but it’s actually returning something more useful.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117135/new/

https://reviews.llvm.org/D117135