[PATCH] D117710: AMDGPU/GlobalISel: Mostly fix BFI patterns

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 20 02:51:11 PST 2022


foad accepted this revision.
foad added a comment.
This revision is now accepted and ready to land.

LGTM, thanks!



================
Comment at: llvm/test/CodeGen/AMDGPU/bfi_int.ll:5
 ; RUN: llc -march=amdgcn -mcpu=gfx1031 -verify-machineinstrs < %s | FileCheck -enable-var-scope -check-prefix=GFX10 %s
+; RUN: llc -global-isel -march=amdgcn -mcpu=tonga -verify-machineinstrs < %s | FileCheck -enable-var-scope -check-prefix=GFX8-GISEL %s
+; RUN: llc -global-isel -march=amdgcn -mcpu=gfx1031 -verify-machineinstrs < %s | FileCheck -enable-var-scope -check-prefix=GFX10-GISEL %s
----------------
Could use a common prefix GFX8 for GFX8-SDAG and GFX8-GISEL, since the simple cases work out identical, and the same for GFX10?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117710/new/

https://reviews.llvm.org/D117710



More information about the llvm-commits mailing list