[PATCH] D117690: AMDGPU/GlobalISel: Directly diagnose return value use for FP atomics

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 20 00:42:44 PST 2022


foad added a comment.

> Previously we were falling back to the DAG on selection
> failure, where it would emit this error and then fail again.

Why is that a problem? Is this just a temporary thing, while you are testing with the fallback to dag enabled?

To put it another way, what's so special about this case that legalization has to fail harder than other cases?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117690/new/

https://reviews.llvm.org/D117690



More information about the llvm-commits mailing list