[PATCH] D116521: [CMake] Factor out config prefix finding logic

[Sebastian Neubauer via Phabricator via llvm-commits]

sebastian-ne added inline comments.


================
Comment at: llvm/CMakeLists.txt:209
   "${CMAKE_CURRENT_SOURCE_DIR}/cmake/modules"
+  "${LLVM_COMMON_CMAKE_UTILS}/Modules"
   )
----------------
Hi, adding this module path overwrites the `llvm_check_linker_flag` from `llvm/cmake/modules/LLVMCheckLinkerFlag.cmake` with the one defined in `cmake/Modules/CheckLinkerFlag.cmake`, which does not check the linker but the compiler.
This breaks our gcc+ld build because ld does not support `--color-diagnostics`.

Our downstream issue is here: https://github.com/GPUOpen-Drivers/llpc/issues/1645


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116521/new/

https://reviews.llvm.org/D116521