[PATCH] D117849: [docs] There are four bit storage containers.
Hsiangkai Wang via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Jan 23 23:45:39 PST 2022
HsiangKai added inline comments.
================
Comment at: llvm/docs/ProgrammersManual.rst:2403
Bit storage containers (BitVector, SparseBitVector, CoalescingBitVector)
------------------------------------------------------------------------
----------------
dexonsmith wrote:
> This should list `SmallBitVector` as well, right?
I removed the container list in the title. I think it is not necessary to list them in the title, just like "String-like containers" section.
================
Comment at: llvm/docs/ProgrammersManual.rst:2406-2407
-There are three bit storage containers, and choosing when to use each is
+There are four bit storage containers, and choosing when to use each is
relatively straightforward.
----------------
dexonsmith wrote:
> Is there a way of wording this to avoid having to update the count in the future? If not, LGTM as is.
How about to use 'several' here?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117849/new/
https://reviews.llvm.org/D117849
More information about the llvm-commits
mailing list