[PATCH] D117889: [RISCV] add support for zbkx subextension in MC layer.

[Xinlong Wu via Phabricator via llvm-commits]

VincentWu added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCV.td:166
+
 def HasStdExtZbpOrZbkb
     : Predicate<"Subtarget->hasStdExtZbp() || Subtarget->hasStdExtZbkb()">,
----------------
you may need rebase again and include `zbxk` into subTargeteature list of `FeatureStdExtZks` & `FeatureStdExtZkn` which is added in https://reviews.llvm.org/D98136.


================
Comment at: llvm/test/CodeGen/RISCV/attributes.ll:93
+; RV64ZBKX: .attribute 5, "rv64i2p0_zbkx1p0"
 
 define i32 @addi(i32 %a) {
----------------
same here


================
Comment at: llvm/test/MC/RISCV/attribute-arch.s:135
+.attribute arch, "rv32i_zbkx1p0"
+# CHECK: attribute      5, "rv32i2p0_zbkx1p0"
----------------
again


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117889/new/

https://reviews.llvm.org/D117889