[PATCH] D98136: [RISCV] Initially support the K-extension instructions on the LLVM MC layer

[Xinlong Wu via Phabricator via llvm-commits]

VincentWu added a comment.

In D98136#3265096 <https://reviews.llvm.org/D98136#3265096>, @craig.topper wrote:

> LGTM

Thanks -)



================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfo.cpp:1150
+        case RISCVOp::OPERAND_RVKRNUM:
+          Ok = Imm >= 0 && Imm <= 10;
         }
----------------
craig.topper wrote:
> Missing "break;" This will be a problem the next time someone adds a case after this one.
oops, sorry my bad, fixed


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98136/new/

https://reviews.llvm.org/D98136