[PATCH] D98136: [RISCV][RFC] Initially support the K-extension instructions on the LLVM MC layer

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfo.cpp:1150
+        case RISCVOp::OPERAND_RVKRNUM:
+          Ok = Imm >= 0 && Imm <= 10;
         }
----------------
Missing "break;" This will be a problem the next time someone adds a case after this one.


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoZk.td:1
+//===- RISCVInstrInfoZk.td - RISC-V Scala Crypto instructions - tablegen -*===//
+//
----------------
Scala -> Scalar


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoZk.td:9
+//
+// This file describes the RISC-V instructions from the standard 'ZK',
+// Scala Cryptography Instructions extension, version 1.0.
----------------
ZK -> Zk


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98136/new/

https://reviews.llvm.org/D98136