[PATCH] D117889: [RISCV][RFC] add support for zbkx subextension in MC layer.

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCV.td:191
+                AssemblerPredicate<(any_of FeatureStdExtZbp, FeatureStdExtZbkx),
+                                   "'Zbp' (Permutation 'B' Instructions) or "
+                                   "'Zbkx' (Crossbar permutation instructions)">;
----------------
Replace 'B' with 'Zb'. I have a patch to fix the existing locations here D117822


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoZb.td:20
 //   Zbr - 0.93
 //   Zbt - 0.93
 //
----------------
Please add Zbkx to the header. I just pushed a commit to add a spot for Zbk* extensions.


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoZb.td:741
 
+// Since Zbp is likely to be picked up in the future, rename previous insts and
+// define aliases for Zbp to keep other codes unchanged. 
----------------
I wouldn't speculate on whether Zbp will be ratified or not. Just say Zbp is unratified and that it would likely adopt the already ratified Zbkx names.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117889/new/

https://reviews.llvm.org/D117889