[PATCH] D117725: [AVR] Fix atomicrmw result value

Ben Shi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 23 08:16:05 PST 2022


benshi001 added inline comments.


================
Comment at: llvm/test/CodeGen/AVR/atomics/load16.ll:32
 ; CHECK-NEXT: cli
 ; CHECK-NEXT: ld [[RR1:r[0-9]+]], [[RD:(X|Y|Z)]]
 ; CHECK-NEXT: ldd [[RR2:r[0-9]+]], [[RD]]+1
----------------
I am OK with this patch. Just a bit confusion.

In the next test file load8.ll, RR1 is the address and RD is the loaded value.
```
ld [[RD:r[0-9]+]], [[RR:(X|Y|Z)]]
```

I suggest you make them in accordance with each other when committing. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117725/new/

https://reviews.llvm.org/D117725



More information about the llvm-commits mailing list