[PATCH] D117281: [llvm-objcopy][MachO] Implement --update-section
Alexander Shaposhnikov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Jan 22 21:46:50 PST 2022
alexander-shaposhnikov added inline comments.
================
Comment at: llvm/tools/llvm-objcopy/MachO/MachOObjcopy.cpp:344
+ return *FoundSec->get();
+ }();
+
----------------
immediately called lambda is unnecessary here,
let's split it out into a helper function
================
Comment at: llvm/tools/llvm-objcopy/MachO/MachOObjcopy.cpp:425
+ StringRef FileName;
+ std::tie(SectionName, FileName) = Flag.split('=');
+ if (Error E = updateSection(SectionName, FileName, Obj))
----------------
we need to validate the name (isValidMachOCannonicalName can be of some help here) (+ test case)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117281/new/
https://reviews.llvm.org/D117281
More information about the llvm-commits
mailing list