[PATCH] D117925: [lld][macho] Add more skip platform check for libSystem re-exports

Byoungchan Lee via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jan 22 18:25:42 PST 2022


bc-lee marked an inline comment as done.
bc-lee added inline comments.


================
Comment at: lld/MachO/InputFiles.cpp:1274
 // platform settings.
-static constexpr std::array<StringRef, 3> skipPlatformChecks{
+static constexpr std::array<StringRef, 4> skipPlatformChecks{
     "/usr/lib/system/libsystem_kernel.dylib",
----------------
MaskRay wrote:
> const at a namespace scope is automatically internal linkage (unless some edge-case conditions) so `static` can be omitted.
Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117925/new/

https://reviews.llvm.org/D117925



More information about the llvm-commits mailing list