[PATCH] D117489: [SDAG] Don't move DBG_VALUE instructions after insertion point during scheduling (PR53243)

[Florian Hahn via Phabricator via llvm-commits]

fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.

LGTM, thanks



================
Comment at: llvm/test/CodeGen/X86/pr53243-tail-call-fastisel.ll:29
+!5 = !DIFile(filename: "<unknown>", directory: "")
+!6 = !DINamespace(name: "option", scope: !7)
+!7 = !DINamespace(name: "core", scope: null)
----------------
nit: most of those namespaces/enumerates should not be needed I think.


================
Comment at: llvm/test/CodeGen/X86/pr53243-tail-call-fastisel.ll:43
+!19 = !DIDerivedType(tag: DW_TAG_member, name: "data_ptr", scope: !17, file: !5, baseType: !20, size: 64, align: 64)
+!20 = !DIDerivedType(tag: DW_TAG_pointer_type, name: "*const u8", baseType: !8, size: 64, align: 64, dwarfAddressSpace: 0)
+!21 = !DIDerivedType(tag: DW_TAG_member, name: "length", scope: !17, file: !5, baseType: !22, size: 64, align: 64, offset: 64)
----------------
nit: most of the types shouldn't be needed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117489/new/

https://reviews.llvm.org/D117489