[PATCH] D116821: [DebugInfo][InstrRef] Move instr-ref controlling flag out of TargetOptions

Sat Jan 22 13:07:21 PST 2022

dblaikie added a comment.

In D116821#3263871 <https://reviews.llvm.org/D116821#3263871>, @xbolva00 wrote:

>>> Similarly, they could use the flag to continue to opt in to the behavior.
>
> Ah yeah, if you meant "revert = set this as false by default" than it is a reasonable thing to do if regressions are too large for common codebases.

Yeah,  that's what I mean - "revert the observable effect of this change". Mechanically I'm open to ideas and I don't think we need to churn this whole patch. Probably would've been good to make the behavior changing patch smaller/simpler so it'd be easy to revert/toggle off, but 'tis what it is. So, yeah, might be suitable to commit a change to the comparisons in `debuginfoShouldUseDebugInstrRef` to disable this functionality for now for further investigation.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116821/new/

https://reviews.llvm.org/D116821