[PATCH] D117889: [RISCV][RFC] add support for zbkx subextension in MC layer.

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoZb.td:742
 
+let Predicates = [HasStdExtZbkx] in {
+  def : InstAlias<"xperm8 $rd, $rs1, $rs2", (XPERMB GPR:$rd, GPR:$rs1, GPR:$rs2)>;
----------------
I'd rename the instructions in Zbp to xperm4 and xperm8 and add xperm.n and xperm.b aliases for Zbp. If Zbp gets picked up in the future, the instructions will likely be renamed to match Zbkx.


================
Comment at: llvm/test/MC/RISCV/attribute-arch.s:136
 # CHECK: attribute      5, "rv32i2p0_zbkc1p0"
+.attribute arch, "rv32i_zbkx1p0"
+# CHECK: attribute      5, "rv32i2p0_zbkx1p0"
----------------
Blank line before to keep consistency.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117889/new/

https://reviews.llvm.org/D117889