[PATCH] D117925: [lld][macho] Add more skip platform check for libSystem re-exports

Fri Jan 21 19:18:13 PST 2022

bc-lee added a comment.

>From what I understand, https://reviews.llvm.org/D100913 ( BZ https://llvm.org/bz49799 GH https://github.com/llvm/llvm-project/issues/49143 ) is for iphonesimulator cases. ld64 is also allowlisting those libraries.

This patch is for the catalyst case, where ld64 doesn't have a separate whitelist, but instead fully allows catalyst binary linking while linking with MacOS dynamic libraries.

The ld64 code related to this is https://github.com/apple-opensource/ld64/blob/e28c028b20af187a16a7161d89e91868a450cadc/src/ld/PlatformSupport.cpp#L177

Maybe we could also allow catalyst binary linking with the all MacOS dynamic libraries, but I don't think this is the best solution.

And I don't have a write access for LLVM, can you commit my changes on behalf of it?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117925/new/

https://reviews.llvm.org/D117925