[PATCH] D117256: [memprof] Introduce a wrapper around MemInfoBlock.

Aditya Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 16 23:33:02 PST 2022


hiraditya added inline comments.


================
Comment at: compiler-rt/include/profile/MemProfData.inc:86
+// Packed struct definition for MSVC. We can't use the PACKED macro defined in
+// MemProfData.inc since it would mean we are embedding a directive (the
+// #include for MIBEntryDef) into the macros which is undefined behaviour.
----------------
by  MemProfData.inc, do we mean 'compiler-rt/include/profile/MemProfData.inc' the current file, or 'include/llvm/ProfileData/MemProfData.inc'?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117256/new/

https://reviews.llvm.org/D117256



More information about the llvm-commits mailing list