[PATCH] D117404: [RISCV] Add patterns for vector widening integer multiply-add instructions

Jianjian Guan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 16 18:32:53 PST 2022


jacquesguan added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoVSDPatterns.td:551
+// 12.14 Vector Widening Integer Multiply-Add Instructions
+multiclass VPatWidenMulAddSDNode_VV<PatFrags extop1, PatFrags extop2, string instruction_name> {
+  foreach vti = AllWidenableIntVectors in {
----------------
I think if move these class definations to upper section near to other class definations and leave pattern def here,  maybe more clear.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117404/new/

https://reviews.llvm.org/D117404



More information about the llvm-commits mailing list