[PATCH] D117387: [lld-macho] Allow deduplicate-literals to be overridden

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai added a comment.

It's worth noting that `-no_deduplicate` in ld64 actually turns off ICF, not string merging. I don't know if ld64 even has a way to turn off string merging, since IIRC it's implemented in the symbol table itself.



================
Comment at: lld/MachO/Driver.cpp:1266
+  config->dedupLiterals =
+      args.hasFlag(OPT_deduplicate_literals, OPT_icf_eq, false) ||
+      config->icfLevel != ICFLevel::none;
----------------
I'm confused ... was the second argument meant to be `OPT_no_deduplicate`? The test seems to be passing though...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117387/new/

https://reviews.llvm.org/D117387