[PATCH] D117433: [RISCV] Implement support for the Zicbop extension

[Alex Bradbury via Phabricator via llvm-commits]

asb planned changes to this revision.
asb added a comment.

This introduces a bug when disassembling ori with =mattr=+zicbop enabled. I've not investigated further yet.



================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoZicbo.td:67
+let Predicates = [HasStdExtZicbop] in {
+def PREFETCH_I : Prefetch_ri<0b00000, "prefetch.i">, Sched<[]>;
+def PREFETCH_R : Prefetch_ri<0b00001, "prefetch.r">, Sched<[]>;
----------------
jrtc27 wrote:
> Shouldn't TableGen be shouting that these encodings overlap with ORI?
You'd have thought so. I should really add tests to this that cover the overlap with ORI - there does seem to be an issue there right now with ori being decoded as prefetch.i unexpectedly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117433/new/

https://reviews.llvm.org/D117433