[lld] 9e885ea - [ELF] Remove !isLazy() condition from computeBinding

Fangrui Song via llvm-commits llvm-commits at lists.llvm.org
Sat Jan 15 23:58:20 PST 2022


Author: Fangrui Song
Date: 2022-01-15T23:58:15-08:00
New Revision: 9e885eac542c408008e135fd43c91b792fb0f264

URL: https://github.com/llvm/llvm-project/commit/9e885eac542c408008e135fd43c91b792fb0f264
DIFF: https://github.com/llvm/llvm-project/commit/9e885eac542c408008e135fd43c91b792fb0f264.diff

LOG: [ELF] Remove !isLazy() condition from computeBinding

Seems applicable since we demote lazy symbols to Undefined (D111365).

Added: 
    

Modified: 
    lld/ELF/Symbols.cpp

Removed: 
    


################################################################################
diff  --git a/lld/ELF/Symbols.cpp b/lld/ELF/Symbols.cpp
index 221a89ac4961..d943c1996422 100644
--- a/lld/ELF/Symbols.cpp
+++ b/lld/ELF/Symbols.cpp
@@ -269,7 +269,7 @@ MemoryBufferRef LazyArchive::getMemberBuffer() {
 
 uint8_t Symbol::computeBinding() const {
   if ((visibility != STV_DEFAULT && visibility != STV_PROTECTED) ||
-      (versionId == VER_NDX_LOCAL && !isLazy()))
+      versionId == VER_NDX_LOCAL)
     return STB_LOCAL;
   if (binding == STB_GNU_UNIQUE && !config->gnuUnique)
     return STB_GLOBAL;


        


More information about the llvm-commits mailing list