[compiler-rt] 1088c78 - [ORC-RT] Remove some stale comments.

Lang Hames via llvm-commits llvm-commits at lists.llvm.org
Sat Jan 15 19:06:34 PST 2022


Author: Lang Hames
Date: 2022-01-16T14:03:15+11:00
New Revision: 1088c78c3b054f73f7d107addd50ee0669bb31be

URL: https://github.com/llvm/llvm-project/commit/1088c78c3b054f73f7d107addd50ee0669bb31be
DIFF: https://github.com/llvm/llvm-project/commit/1088c78c3b054f73f7d107addd50ee0669bb31be.diff

LOG: [ORC-RT] Remove some stale comments.

We switched to SPS serialization for these functions in 089acf25223d2.

Added: 
    

Modified: 
    compiler-rt/lib/orc/macho_platform.cpp

Removed: 
    


################################################################################
diff  --git a/compiler-rt/lib/orc/macho_platform.cpp b/compiler-rt/lib/orc/macho_platform.cpp
index e2666aa452c8..f2cca8eb829a 100644
--- a/compiler-rt/lib/orc/macho_platform.cpp
+++ b/compiler-rt/lib/orc/macho_platform.cpp
@@ -593,8 +593,6 @@ __orc_rt_macho_platform_shutdown(char *ArgData, size_t ArgSize) {
 
 ORC_RT_INTERFACE __orc_rt_CWrapperFunctionResult
 __orc_rt_macho_register_thread_data_section(char *ArgData, size_t ArgSize) {
-  // NOTE: Does not use SPS to deserialize arg buffer, instead the arg buffer
-  // is taken to be the range of the thread data section.
   return WrapperFunction<SPSError(SPSExecutorAddrRange)>::handle(
              ArgData, ArgSize,
              [](ExecutorAddrRange R) {
@@ -606,8 +604,6 @@ __orc_rt_macho_register_thread_data_section(char *ArgData, size_t ArgSize) {
 
 ORC_RT_INTERFACE __orc_rt_CWrapperFunctionResult
 __orc_rt_macho_deregister_thread_data_section(char *ArgData, size_t ArgSize) {
-  // NOTE: Does not use SPS to deserialize arg buffer, instead the arg buffer
-  // is taken to be the range of the thread data section.
   return WrapperFunction<SPSError(SPSExecutorAddrRange)>::handle(
              ArgData, ArgSize,
              [](ExecutorAddrRange R) {


        


More information about the llvm-commits mailing list