[PATCH] D116913: [lld-macho] Add --start-lib --end-lib

[Fangrui Song via Phabricator via llvm-commits]

MaskRay marked an inline comment as done.
MaskRay added inline comments.


================
Comment at: lld/MachO/Driver.cpp:250
 static DenseMap<StringRef, ArchiveFile *> loadedArchives;
+static bool inLib;
 
----------------
oontvoo wrote:
> can this be a parameter to the addFile() function instead?
> 
> Having it as a global makes it harder to introduce any kind parallelization in processing the input (which i'm working on a POC for,  since lld-macho is currently proven to be too slow to link Youtube)
> 
> Also I've said this on the bug but I'm kind concerned about introducing stateful flags like this given there's no precedence for it in LD64.
Removed. The state would not make parallelization more difficult. We do not parallelize the addFile function calls but the underlying initialization.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116913/new/

https://reviews.llvm.org/D116913