[PATCH] D117363: LLDB Windows x64 buildbot set lit -j8

Galina via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 14 23:10:07 PST 2022


gkistanova added a comment.

> What about adding a separate parameter for the jobs for the tests? That way a different level of parallelism could be specified for build and test? That's the route I would have gone.

I would guess a particular value depends on available worker hardware resources. So, it could be a property, something like a `lit_jobs`, which gets rendered to  `LLVM_LIT_ARGS` if defined. Similar how `jobs` property is defined for workers.

  # Windows Server 2016 Intel Xeon(R) Quad 2.30 GHz, 56GB of RAM
  create_worker("win-py3-buildbot", properties={'jobs' : 64, 'lit_jobs' : 8}, max_builds=1),



> I conveniently copied lit args from arm lldb bot. AFAIK both giving and sv together shows output as well as a progress bar but I am not too sure.

I see. The current LIT implementation ignores `-v` and executes `-s` no matter in what order they are specified. So, you need the one or the other, not two together. With automated builds, you may want -v, as it prints more information which could be useful for troubleshooting build issues and test failures.

Anyway, feel free to commit this patch as is. It would solve your immediate problem and everything else we are discussing here could be done as a follow up.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117363/new/

https://reviews.llvm.org/D117363



More information about the llvm-commits mailing list