[PATCH] D117270: Revert "[X86][LLD] Update datelayout in LLD tests. NFCI"

Phoebe Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 14 19:01:57 PST 2022


pengfei abandoned this revision.
pengfei added a comment.

In D117270#3244523 <https://reviews.llvm.org/D117270#3244523>, @dexonsmith wrote:

> In D117270#3244517 <https://reviews.llvm.org/D117270#3244517>, @dexonsmith wrote:
>
>> Changes that are helping bots recover usually don't get a reviewed ahead of landing. Next time just push the revert to fix the bot! (LGTM)
>
> Nevermind, looking closer, this isn't a simple revert. I'll resign as reviewer so someone can look at the autoupgrade changes.
>
> If I were you, I'd revert the original commit and the incorrect testcase fix in lld (without review) and then post a review for relanding with autoupgrade working correctly.

I was hesitating on it too. Reverted, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117270/new/

https://reviews.llvm.org/D117270



More information about the llvm-commits mailing list