[PATCH] D117356: InstructionCombining: avoid eliding mismatched alloc/free pairs

Yuanfang Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 14 15:53:27 PST 2022


ychen added a comment.

In D117356#3245161 <https://reviews.llvm.org/D117356#3245161>, @durin42 wrote:

> Ah, @jyknight bailed me out. That's https://github.com/llvm/llvm-project/issues/40384 which looks related, yes. I suspect that would be resolved by this patch.

Agreed that this patch could fix it. However, the underlying issue is that the mismatch is generated by LLVM itself. IMHO preventing the mismatch is a better approach (which D97735 <https://reviews.llvm.org/D97735> would do, I think we should land that instead. @rsmith (thought?)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117356/new/

https://reviews.llvm.org/D117356



More information about the llvm-commits mailing list