[PATCH] D117180: [BasicAliasAnalysis] Switch from isMallocOrCallocLikeFn to onlyAccessesInaccessibleMemory

[Bryce Wilson via Phabricator via llvm-commits]

Bryce-MW added a comment.

I've reverted it. That's quite significant. I'm not sure what we should do here. The current situation is incorrect but as we've seen fixing it causes significant regression. I'm guessing even if op new can't technically be considered inaccessiblememonly in the general case, it probably is commonly inaccessiblememonly which is why this worked in the past. I'm not familiar enough with clang to know if it could say add the annotation if linking against a library that is known to have op new be inaccessiblememonly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117180/new/

https://reviews.llvm.org/D117180