[PATCH] D117363: LLDB Windows x64 buildbot set lit -j8

[Stella Stamenova via Phabricator via llvm-commits]

stella.stamenova added inline comments.


================
Comment at: buildbot/osuosl/master/config/builders.py:1209
                         '-DLLVM_ENABLE_ASSERTIONS=OFF',
+                        '-DLLVM_LIT_ARGS=-svj 8',
                         '-DLLVM_ENABLE_ZLIB=FALSE',
----------------
omjavaid wrote:
> stella.stamenova wrote:
> > Right now the `getLLDBCMakeBuildFactory` function will separately set `LLVM_LIT_ARGS` as well. I think they should be set in just one place to make the code more readable. Perhaps we can remove the `LLVM_LIT_ARGS` from `getLLDBCMakeBuildFactory` if they are not used anywhere?
> extra flags override those as they appended last to cmake_options. That way we set lit args in case use has not supplied any specific ones in extra_cmake_args.
OK, if @gkistanova is OK with this approach also, it's fine by me.


================
Comment at: buildbot/osuosl/master/config/builders.py:1209
                         '-DLLVM_ENABLE_ASSERTIONS=OFF',
+                        '-DLLVM_LIT_ARGS=-svj 8',
                         '-DLLVM_ENABLE_ZLIB=FALSE',
----------------
stella.stamenova wrote:
> omjavaid wrote:
> > stella.stamenova wrote:
> > > Right now the `getLLDBCMakeBuildFactory` function will separately set `LLVM_LIT_ARGS` as well. I think they should be set in just one place to make the code more readable. Perhaps we can remove the `LLVM_LIT_ARGS` from `getLLDBCMakeBuildFactory` if they are not used anywhere?
> > extra flags override those as they appended last to cmake_options. That way we set lit args in case use has not supplied any specific ones in extra_cmake_args.
> OK, if @gkistanova is OK with this approach also, it's fine by me.
Why `-s` (succinct)?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117363/new/

https://reviews.llvm.org/D117363