[PATCH] D117273: [lld-macho] Simplify DeduplicatedCStringSection::finalizeContents. NFC

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 14 13:08:04 PST 2022


MaskRay added a comment.

In D117273#3244787 <https://reviews.llvm.org/D117273#3244787>, @int3 wrote:

> Could you include in the commit message the size % change when linking chromium_framework?

There is no observable difference, likely because the string section size is small (`__cstring        007a31a1`).

ld64 does not concatenate debug info so the biggest bottleneck (`.debug_str`) on ELF is not a problem for Mach-O...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117273/new/

https://reviews.llvm.org/D117273



More information about the llvm-commits mailing list