[PATCH] D117252: [InstCombine] Fold ashr-exact into a icmp-ugt.

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 14 10:49:53 PST 2022


spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.

In D117252#3244304 <https://reviews.llvm.org/D117252#3244304>, @nadav wrote:

> @spatel Thank you for the review. I added the pre-commit tests in a new diff (https://reviews.llvm.org/D117338).  I've also made the changes to the comment as you suggested. Are you willing to approve the diff or do you want to see the comment and do another round of review?

I don't have anything other than the minor feedback, so no, I don't need another round of review. LGTM.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117252/new/

https://reviews.llvm.org/D117252



More information about the llvm-commits mailing list