[PATCH] D116928: [LoopVectorize] Support epilogue vectorisation of loops with reductions

[Bardia Mahjour via Phabricator via llvm-commits]

bmahjour added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:563
+  // generated by fixReduction.
+  PHINode *getResumeValue(const RecurrenceDescriptor &RdxDesc);
+
----------------
suggestion: rename to `getReductionResumeValue` (to distinguish it from "induction resume" values).


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:834
+  // correct start value of reduction PHIs when vectorizing the epilogue.
+  SmallMapVector<const RecurrenceDescriptor *, PHINode *, 4> ResumeValues;
 };
----------------
suggestion: rename to `ReductionResumeValues`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116928/new/

https://reviews.llvm.org/D116928