[PATCH] D117110: [InstCombine] try to fold binop with phi operands

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 14 09:02:57 PST 2022


spatel added inline comments.


================
Comment at: llvm/test/Transforms/InstCombine/zext-or-icmp.ll:42
 
 define i32 @dont_widen_undef() {
 ; CHECK-LABEL: @dont_widen_undef(
----------------
spatel wrote:
> spatel wrote:
> > aeubanks wrote:
> > > these tests need to be changed to preserve testing of https://reviews.llvm.org/D30781
> > I think these tests were already altered enough (there's no shift remaining in the existing CHECK lines) that they don't test the original problem (undefined shift). I'll try to come up with another way to cover that path.
> Extra test added here:
> 417f5f4633e
lost a char:
f417f5f4633e


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117110/new/

https://reviews.llvm.org/D117110



More information about the llvm-commits mailing list