[PATCH] D117223: [GlobalOpt] Make global SRA offset based

Fri Jan 14 08:59:57 PST 2022

reames accepted this revision.
reames added a comment.
This revision is now accepted and ready to land.

In D117223#3244011 <https://reviews.llvm.org/D117223#3244011>, @nikic wrote:

> The old code doesn't handle this either, because isSafeSROAGEP() checks that all indices are constant integers.

What had confused me is that we have an early continue in the loop for structs which seemed to allow non-constant operands.  I just realized that this is relying on the verifier to disallow non-constant struct indices.  Dang that is subtle for no particular reason.

Given that LGTM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117223/new/

https://reviews.llvm.org/D117223