[PATCH] D116174: [clang] support relative roots to vfs overlays

[Richard Howell via Phabricator via llvm-commits]

rmaz added a comment.

In D116174#3242087 <https://reviews.llvm.org/D116174#3242087>, @benlangmuir wrote:

> Each VFS may have its own working directory, so it could be surprising if we use the OS working directory instead of that.  This is complicated by the fact the VFS working directory may not be set yet during parsing the yaml (I haven't checked).  I'm not really sure what to recommend here. If we do change this, we should document the new behaviour in the doc comment for RedirectingFileSystem though.

I don't believe the working directory will be set on the VFS at this point, no. If you're happy with the change then i'll update the header docs to describe this behaviour, unless there is another way to achieve using relative paths for root entries in the overlay yaml?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116174/new/

https://reviews.llvm.org/D116174