[PATCH] D117226: [OpenMPIRBuilder] Detect and fix ambiguous InsertPoints for createParallel.

[Kiran Chandramohan via Phabricator via llvm-commits]

kiranchandramohan added a comment.

Nit: It seems the same code is codded to quite a few tests. Would it make sense to factor out the common portion?



================
Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:542
     omp::ProcBindKind ProcBind, bool IsCancellable) {
+  assert(!isConflictIP(Loc.IP, OuterAllocaIP) && "IPs must not me ambiguous");
+
----------------
Nit: me -> be


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117226/new/

https://reviews.llvm.org/D117226