[PATCH] D116327: [Coroutines] Enhance symmetric transfer for constant CmpInst

Dmitry Sidorov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 14 05:05:46 PST 2022


sidorovd added a comment.

@ChuanqiXu hi, with this patch the generated LLVM IR snippet is looking like:

  %_Z5task0v.Frame = type { void (%_Z5task0v.Frame*)*, void (%_Z5task0v.Frame*)*, %struct.TaskPromise, i1 }

(see https://godbolt.org/z/b3s9a4xnW - it's the same example from the patch's headed, but with -S -emit-llvm).

In the following patch you add a regression test clang/test/CodeGenCoroutines/coro-elide.cpp , which checks an opposite, which is a bit confusing

  // CHECK: %_Z5task1v.Frame = type {{.*}}%_Z5task0v.Frame

Is it a typo or it was done intentional?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116327/new/

https://reviews.llvm.org/D116327



More information about the llvm-commits mailing list