[PATCH] D116976: [CMake] Passthrough OSX CMake options to builtins and runtimes

[Petr Hosek via Phabricator via llvm-commits]

phosek added a comment.

In D116976#3242390 <https://reviews.llvm.org/D116976#3242390>, @smeenai wrote:

> Actually, could you give an example of the type of variables you want to pass in? I thought the CMAKE_OSX_* options were mostly for setting OS and architecture, which the Darwin compiler-rt build does itself anyway.

Yes, the concrete example we ran into recently is `CMAKE_OSX_DEPLOYMENT_TARGET` which is set here https://github.com/llvm/llvm-project/blob/58ec17cb4ea4f3b76f0c948cf4c894ea7ea43552/clang/cmake/caches/Fuchsia-stage2.cmake#L49. In the future I'd also like to take advantage of `CMAKE_OSX_ARCHITECTURES` to build libc++ as a universal library.

I'm not particular happy with this approach since the runtimes build might accidentally pick up a flag you didn't intend to, which is the motivation for D117263 <https://reviews.llvm.org/D117263>.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116976/new/

https://reviews.llvm.org/D116976