[PATCH] D117250: [lld-macho] Mention string literal deduplication as a difference from ld64

[Vy Nguyen via Phabricator via llvm-commits]

oontvoo added a comment.

In D117250#3242407 <https://reviews.llvm.org/D117250#3242407>, @keith wrote:

> , I wonder how folks would feel about adding one for that case.

>From slightly biased opinions of my colleagues, this would cause quite a bit of false positives. (eg., code that handles buffers)

> I also tested with ubsan and it doesn't warn for this either.

it's not UB to compare two `const char*` - it is kind of UB to *expect* their equality, which, of course, is hard to tell.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117250/new/

https://reviews.llvm.org/D117250