[PATCH] D117254: [ADT] Fix Optional<> with llvm::is_trivially_move_constructible

[Steven Wu via Phabricator via llvm-commits]

steven_wu added inline comments.


================
Comment at: llvm/include/llvm/ADT/Optional.h:57
                                !std::is_move_constructible<T>::value) &&
                               (std::is_trivially_move_assignable<T>::value ||
                                !std::is_move_assignable<T>::value))>
----------------
jplayer-nv wrote:
> I don't have a test in mind yet, but any concern for the same instantiation bug with `std::is_trivially_move_assignable` pre-gcc7.4?
I am not sure and we also do not have a LLVM version of that implementation. Maybe we can address that in a separate patch if that is a problem?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117254/new/

https://reviews.llvm.org/D117254