[PATCH] D117235: [SelectionDAG][VP] Add splitting/widening for VP_LOAD and VP_STORE

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 13 15:43:56 PST 2022


craig.topper added a comment.

Is it worth testing a case that needs widening followed by splitting. Basically any non-power of 2 that rounds up to something that needs splitting. Bonus points if it needs enough splitting to trigger the `HiIsEmpty` is empty case.

I'm not sure we should be widening masked loads/stores or VP loads/stores to power of 2 that needs splitting. It causes the splitting logic to need to deal with odd memory VTs and infer a lot from the memory VT. I think we should be "widening" the load/stores by blocking it into legal pieces as we go like we do for regular loads/stores. But I've thought that for 2 years and haven't done anything about it. So that shouldn't block this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117235/new/

https://reviews.llvm.org/D117235



More information about the llvm-commits mailing list